Project 5: Griffin Evans - #14
Open
grievans wants to merge 20 commits into
Open
Conversation
…to load up in live deploy
…ly so leaving as is for now so I can go home and eat
Author
|
Sorry for the delay in actually submitting the pull request; wanted to be thorough in feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/grievans/Project5-WebGPU-Gaussian-Splat-Viewer/tree/main
https://grievans.github.io/Project5-WebGPU-Gaussian-Splat-Viewer/
Features
Feedback:
glm::mat3 cov = glm::transpose(T) * glm::transpose(Vrk) * T;being followed shortly after byfloat det = (cov.x * cov.z - cov.y * cov.y);which does not make it at all clear how this 3x3 matrix has suddenly become a 3x1 vector—it's actually another variable with the same name that just took some of the values from that matrix, but without looking at the linked code I felt I had no way to know what was going on.