Skip to content

Lab 2: Jacky Park #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jackypark9852 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Lab 2: Jacky Park #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,14 @@ Extra credit if you can find all FIVE bugs.
- In the README, create a link to your shader toy solution with the bugs corrected
- In the README, describe each bug you found and include a sentence about HOW you found it.
- Make sure all three of your shadertoys are set to UNLISTED or PUBLIC (so we can see them!)

# Submission info
- [Fixed shader](https://www.shadertoy.com/view/wcsfDf)
- Team members: Ruben, Eli

# Bugs found
1. compilation error in `main()`. Folllowed the compilatiton error message.
2. passed in `uv` instead of `uv2` into raycast. Checked logic flow in the `main()` function.
3. used `iResolution.x` instead of `iResolution.y` in H calculation. Looked for reasons why the image might be horizontally stretched.
4. insufficient march steps in `march()`. Observed warping only near circles.
5. passed incorrect variables (`eye` instead of `dir`) into `reflect()`. Specular reflection looked off even though the normal was correct.