Skip to content

Lab2: Zixiao Wang #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lanbiubiu1 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Lab2: Zixiao Wang #24

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21f98c5
Update README.md
Lanbiubiu1 Sep 17, 2025
67bb42d
Update README.md
Lanbiubiu1 Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# lab02-debugging

[shadertoy](https://www.shadertoy.com/view/wcsBWf)


1. Line 102, vec uv2 = 2.0 * uv - vec2(1.0); uses an invalid type vec instead of vec2. This cause a compilation error since vec is not a valid GLSL type
2. Line 106, raycast(uv, dir, eye, ref); passes the [0,1] coordinates instead of the [-1,1] coordinates that were calculated in uv2. I saw that uv2 was calculated to convert from [0,1] to [-1,1] range, but then wasn't actually used.
3. Line 13, line H *= len * iResolution.x / iResolution.x; divides x by x, which equals 1, causing an incorrect aspect ratio. I noticed the division was x/x = 1 instead of x/y, which cause the image to appear stretched
4. Line 79, In the sdf3D function, dir = reflect(eye, nor); uses the eye position instead of the ray direction for reflection calculation. I recognized that the reflect() function expects an incident direction vector.
5. Line 21, we need more iterations to find hits.

# Setup

Create a [Shadertoy account](https://www.shadertoy.com/). Either fork this shadertoy, or create a new shadertoy and copy the code from the [Debugging Puzzle](https://www.shadertoy.com/view/flGfRc).
Expand Down