Open
Conversation
Collaborator
Author
|
Another funky error when trying to run |
JordanLaserGit
approved these changes
Mar 9, 2026
Collaborator
JordanLaserGit
left a comment
There was a problem hiding this comment.
Thanks for this feature @quinnylee! This looks ready to merge, though could you add a pytest that performs a prep_ngen_data() call for troute restart files? Ideally we have unit tests for each of the new functions, but I'm happy with just one test to make sure the feature works.
Collaborator
Author
|
Here's a bunch of unit tests and a full |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #66
Adds functionality to generate t-route restarts from NWM standard analysis/assimilation outputs.
Additions
prep_ngen_datainprocessor.pyto see if we are preprocessing atmospheric forcings, channel routing runoff, or t-route restartsTesting
3. Attempted to run new t-route restart example and pytests locally on Ubuntu/x86. I get very strange errors when forcingprocessor tries to read the NWM output file:Edit: moved error documentation here pytests failing on ubuntu/x86 #68
But since NRDS runs on arm nodes I'm inclined to not worry very much about this
Notes
Todos
h5netcdf issue (?)resolved by settingh5py==3.11.0Checklist
Testing checklist
Target Environment support
Other