Skip to content

Pull deps image on ARM when unchanged, add push retry #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harshavemula-ua merged 2 commits into from
Feb 20, 2026
Merged

Pull deps image on ARM when unchanged, add push retry #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3034902
Upgrade ARM CI instances to m8g.xlarge and add push retry logic
harshavemula-ua Feb 20, 2026
119dc87
Address Copilot review: redirect push output to log file and skip sle…
harshavemula-ua Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/executions/fp_ds_test_execution_arm.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"instance_parameters" :
{
"ImageId" : "ami-01fc4c78425e127e6",
"InstanceType" : "t4g.large",
"InstanceType" : "m8g.xlarge",
"KeyName" : "actions_key_arm",
"SecurityGroupIds" : ["sg-0fcbe0c6d6faa0117"],
"IamInstanceProfile": {
Expand Down
2 changes: 1 addition & 1 deletion .github/executions/fp_push_execution_arm.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"instance_parameters" :
{
"ImageId" : "ami-01fc4c78425e127e6",
"InstanceType" : "t4g.large",
"InstanceType" : "m8g.xlarge",
"KeyName" : "actions_key_arm",
"SecurityGroupIds" : ["sg-0fcbe0c6d6faa0117"],
"IamInstanceProfile": {
Expand Down
26 changes: 17 additions & 9 deletions docker/docker_loginNpush.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,16 +53,24 @@ echo "$DOCKERHUB_TOKEN" | docker login -u awiciroh --password-stdin >> "$LOG_FIL
}
log "✓ Docker login successful"

# Push function
# Push function with retry logic
push_image() {
local image=$1 tag=$2
log "Pushing $image:$tag and latest-arm64..."

docker tag "awiciroh/$image:latest-arm64" "awiciroh/$image:$tag" >> "$LOG_FILE" 2>&1
docker push "awiciroh/$image:$tag" >> "$LOG_FILE" 2>&1
docker push "awiciroh/$image:latest-arm64" >> "$LOG_FILE" 2>&1

log "✓ Successfully pushed $image:$tag"
local image=$1 tag=$2 max_retries=3
for i in $(seq 1 $max_retries); do
log "Pushing $image:$tag (attempt $i/$max_retries)..."
if docker tag "awiciroh/$image:latest-arm64" "awiciroh/$image:$tag" >> "$LOG_FILE" 2>&1 && \
docker push "awiciroh/$image:$tag" >> "$LOG_FILE" 2>&1 && \
docker push "awiciroh/$image:latest-arm64" >> "$LOG_FILE" 2>&1; then
log "✓ Successfully pushed $image:$tag"
return 0
fi
if [ "$i" -lt "$max_retries" ]; then
log "Attempt $i failed, retrying in 10s..."
sleep 10
fi
done
log "✗ Failed to push $image:$tag after $max_retries attempts"
return 1
}

# Push all queued images
Expand Down
Loading