don't rely on float precision since it can cause issues #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Different JIT versions (definitely will) & the CPU FPU could result in different results since they might handle floats differently since precision can differ. For Angle's we round to 4 digits, for Vector's we round to 5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different JIT versions (definitely will) & the CPU FPU could result in different results since they might handle floats differently since precision can differ. For Angle's we round to 4 digits, for Vector's we round to 5.
I had encountered this with HolyLib where with a newer JIT version, floats were handled differently when precision became an issue.