Fixing arrest;Renaming freezeprops file #100
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrefgtzweve
reviewed
Jul 14, 2022
sarahsturgeon
requested changes
Jul 16, 2022
Comment on lines
+6
to
+23
| local function isTargetPlayer( ply, targetPlayers ) | ||
| for _, p in pairs( targetPlayers ) do | ||
| if p == ply then | ||
| return true | ||
| end | ||
| end | ||
|
|
||
| return false | ||
| end | ||
|
|
||
| function cmd.arrest( callingPlayer, targetPlayers ) | ||
| local entities = ents.GetAll() | ||
| local entCount = 0 | ||
| local entCounts = {} | ||
|
|
||
| for _, ent in ipairs( entities ) do | ||
| local owner = ent.CPPIGetOwner and ent:CPPIGetOwner() | ||
| if owner and entCounts[owner] then | ||
| if owner and isTargetPlayer( owner ) then |
There was a problem hiding this comment.
Instead we could make a lookup table first, which would only loop through the players once
function cmd.arrest( callingPlayer, targetPlayers )
local entities = ents.GetAll()
local entCount = 0
local entCounts = {}
local targetLookup= {}
for _, ply in ipairs( targetPlayers ) do
targetLookup[ply] = true
end
for _, ent in ipairs( entities ) do
local owner = ent.CPPIGetOwner and ent:CPPIGetOwner() or ent:GetOwner()
if owner and targetLookup[owner] then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.