Skip to content

Conversation

sei-vsarvepalli
Copy link
Contributor

Attempt to resolve #982 issue - let the testing begin..

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes escape sequences from hash (#) characters in namespace regex patterns across the codebase. The change is attempting to resolve issue #982 by modifying how hash symbols are handled in pattern matching for namespaces.

  • Updates the Python regex pattern definitions to use literal hash characters instead of escaped ones
  • Synchronizes corresponding JSON Schema patterns to match the updated Python patterns

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/ssvc/utils/patterns.py Updates regex pattern variables to use # instead of \\# for namespace fragments
data/schema/v2/SsvcObjectRegistry_2_0_0.schema.json Updates pattern validation regex to use # instead of \\# in two locations
data/schema/v2/SelectionList_2_0_0.schema.json Updates pattern validation regex to use # instead of \\#
data/schema/v2/DecisionTable_2_0_0.schema.json Updates pattern validation regex to use # instead of \\# in two locations
data/schema/v2/DecisionPoint_2_0_0.schema.json Updates pattern validation regex to use # instead of \\#
data/schema/v2/DecisionPointGroup_2_0_0.schema.json Updates pattern validation regex to use # instead of \\#

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sei-vsarvepalli sei-vsarvepalli marked this pull request as ready for review September 25, 2025 20:00
@bernhardreiter
Copy link
Contributor

I've also created #984 that adds the removal of \\# as sed command

@sei-vsarvepalli
Copy link
Contributor Author

superseeded by @bernhardreiter PR #984

@sei-vsarvepalli
Copy link
Contributor Author

using #984 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ajv fails with new namespace regular expression
2 participants