Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote instance feature #31

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Remote instance feature #31

wants to merge 1 commit into from

Conversation

psrok1
Copy link
Member

@psrok1 psrok1 commented Mar 11, 2021

As in documentation:

image

image

:type raise_not_found: bool
:rtype: :class:`MWDBBlob` or None (if raise_not_found=False)
:raises: requests.exceptions.HTTPError
def list_remotes(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about using a more logic name? list_remotes makes it sounds like the function will print out a listing of the remotes. Maybe something like get_remotes or enumerate_remotes?

@msm-code
Copy link
Contributor

@psrok1 is it ready to be merged?

@psrok1
Copy link
Member Author

psrok1 commented Oct 30, 2021

@psrok1 is it ready to be merged?

Not yet because the naming could be a bit better (as @nazywam said). I will come back to it soon.

@psrok1 psrok1 marked this pull request as draft February 22, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants