Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another bunch of fixes to correctly delete users #918

Merged
merged 4 commits into from
Feb 26, 2024
Merged

Conversation

psrok1
Copy link
Member

@psrok1 psrok1 commented Feb 23, 2024

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running the project, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?

User can't be deleted if issued any API key for another user or registered another user. NULL values are already expected in these fields by frontend and backend code, but constraints and cascades were set incorrectly.

What is the new behaviour?

User can be deleted and issued_by and registered_by columns are just NULLed.

@psrok1 psrok1 added the type:bug Something isn't working label Feb 23, 2024
@psrok1 psrok1 force-pushed the fix/deleting-users-2 branch from 600b7a4 to 3439346 Compare February 26, 2024 13:01
@psrok1 psrok1 force-pushed the fix/deleting-users-2 branch from 00a1ab9 to 3b79c9c Compare February 26, 2024 14:14
@psrok1 psrok1 merged commit 081f325 into master Feb 26, 2024
12 checks passed
@psrok1 psrok1 deleted the fix/deleting-users-2 branch February 26, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant