Monitor deprecated API usage via Prometheus metrics #910
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
What is the current behaviour?
MWDB Core has few deprecated features that are waiting for removal. To be sure that we won't break anything, we need to monitor usage of these features.
What is the new behaviour?
Previously monitoring was done via
logger.warning
but it appeared to be pretty inefficient with current amount of deprecated things. In addition, not all deprecated features have been covered. This PR notifies about deprecated API usage via Prometheus metrics (introduced in #908) and debug-level logs.Another important change is rename from
api_requests
tomwdb_api_requests
, it's more convenient to have prefixed metric names.