Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor deprecated API usage via Prometheus metrics #910

Merged
merged 4 commits into from
Feb 15, 2024

Conversation

psrok1
Copy link
Member

@psrok1 psrok1 commented Feb 13, 2024

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running the project, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?

MWDB Core has few deprecated features that are waiting for removal. To be sure that we won't break anything, we need to monitor usage of these features.

What is the new behaviour?

Previously monitoring was done via logger.warning but it appeared to be pretty inefficient with current amount of deprecated things. In addition, not all deprecated features have been covered. This PR notifies about deprecated API usage via Prometheus metrics (introduced in #908) and debug-level logs.

Another important change is rename from api_requests to mwdb_api_requests, it's more convenient to have prefixed metric names.

@psrok1 psrok1 merged commit d01ad64 into master Feb 15, 2024
12 checks passed
@psrok1 psrok1 deleted the feature/deprecated-api-metrics branch February 15, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant