Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dots in user and group names #1014

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

psrok1
Copy link
Member

@psrok1 psrok1 commented Jan 9, 2025

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running the project, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?

I noticed this problem during integration with OIDC SSO where dots were used in preferred usernames. We don't have any good reason to ban this character.

What is the new behaviour?

Dots are allowed in user and group names.

@psrok1 psrok1 merged commit f5799d8 into master Jan 9, 2025
12 checks passed
@psrok1 psrok1 deleted the feature/allow-dots-in-username branch January 9, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant