Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons to implement that:
share_3rd_party
header within karton-archive-extractor.quality
that needs to be passed manually from task to task: https://github.com/CERT-Polska/karton-classifier/blob/master/karton/classifier/classifier.py#L102Few design details:
self.headers
collection so it was important also for compatibility.headers_persistent
goes to the serialized JSON as well. Values contained there always take precedence overheaders
, so it should be consistent.payload_persistent
, because older consumer making a newTask(...)
will pass headers without persistent ones so they will be lost. As we keep it inpayload_persistent
, they will be placed back inheaders_persistent
during deserialization made bykarton.system