Skip to content

Updates for Custom Questions#636

Merged
jupiter007 merged 6 commits intodevelopmentfrom
feature/130/JS-custom-question-updates
Mar 16, 2026
Merged

Updates for Custom Questions#636
jupiter007 merged 6 commits intodevelopmentfrom
feature/130/JS-custom-question-updates

Conversation

@jupiter007
Copy link
Collaborator

Description

  • Added guidanceText and sampleText fields to addQuestionCustomization and added json, questionText, requirementText, guidanceText, sampleText, useSampleTextAsDefault and required to addCustomQuestionInput
  • Added questionCustomizationByVersionedQuestion resolver
  • Added findByCustomizationAndVersionedQuestion method to QuestionCustomization model
  • Fixed fetchTemplateData query in TemplateCustomization model because questionCustomizationHasSampleText was incorrectly returning true

Fixes # (130)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Manually tested with frontend and also with new unit tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I updated the CHANGELOG.md and added documentation if necessary
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

…ceText and sampleText for addQuestionCustomization and added a new findByCustomizationAndVersionedQuestion function for QuestionCustomization model
if [ -f "/etc/mysql-cert.pem" ]; then
MIGRATION_ARGS="${MIGRATION_ARGS} --ssl-ca=/etc/mysql-cert.pem --ssl-verify-server-cert=OFF"
fi
MIGRATION_ARGS="${MIGRATION_ARGS} --ssl=off"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -ssl-verify-server-cert=OFF" was not working for me and the nuke-db.sh was breaking so I switched to using --ssl=off for both this and process.sh and it worked

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you leave the --ssl-verify-server-cert=OFF commented out below the line?

I'm not sure why our mariadb would be different, but I'd prefer to keep that there in case I need to use it on mine

Copy link
Collaborator

@briri briri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @jupiter007 Please just leave that ssl argument commented out below for me in case we need to use it. I'm not sure why our local machines would treat it differently.

if [ -f "/etc/mysql-cert.pem" ]; then
MIGRATION_ARGS="${MIGRATION_ARGS} --ssl-ca=/etc/mysql-cert.pem --ssl-verify-server-cert=OFF"
fi
MIGRATION_ARGS="${MIGRATION_ARGS} --ssl=off"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you leave the --ssl-verify-server-cert=OFF commented out below the line?

I'm not sure why our mariadb would be different, but I'd prefer to keep that there in case I need to use it on mine

@jupiter007 jupiter007 merged commit 258b9bf into development Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants