Use functions from PyRenew time.py in pyrenew_hew_data.py

[cdc-mitzimorris]

Changes to pyernew_hew_data.py to use helper functions in PyRenew's time.py where possible.

[Copilot]

Pull request overview

This PR refactors pyrenew_hew_data.py to use utility functions from PyRenew's time.py module instead of maintaining duplicate implementations locally. This improves code maintainability by leveraging shared library functions for common date/time operations.

Key Changes:

• Replaced local get_n_data_days(), get_end_date(), and validation logic with PyRenew's get_n_data_days(), get_end_date(), validate_mmwr_dates(), and create_date_time_spine() functions
• Updated parameter naming from n_datapoints to n_points to match PyRenew's API conventions
• Updated test error message pattern to match the PyRenew validation function's error message

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
pyrenew_hew/pyrenew_hew_data.py	Removed duplicate date/time utility methods (~48 lines) and replaced their usages with PyRenew imports, simplifying the codebase and ensuring consistency with PyRenew's API
tests/test_pyrenew_hew_data.py	Updated error message regex from "Saturdays.*MMWR epiweek" to "MMWR dates must be Saturdays" to match PyRenew's validate_mmwr_dates() error message

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.88%. Comparing base (758d34b) to head (c16753c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #742      +/-   ##
==========================================
- Coverage   26.28%   25.88%   -0.41%     
==========================================
  Files          26       26              
  Lines        2427     2411      -16     
==========================================
- Hits          638      624      -14     
+ Misses       1789     1787       -2     

Flag	Coverage Δ
hewr	29.93% <ø> (ø)
pipelines	3.05% <ø> (ø)
pyrenew_hew	63.38% <100.00%> (-0.69%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[damonbayer]

I don't think the time functions are being exposed in pyrenew.

[cdc-mitzimorris]

I don't think the time functions are being exposed in pyrenew.

the problem is here:

pyrenew-hew/pyproject.toml

Line 61 in bb18afd

pyrenew = { git = "https://github.com/CDCgov/PyRenew", rev = "v0.1.5" }

why did this get pinned to "v0.1.5" and should it be unpinned?

[damonbayer]

why did this get pinned to "v0.1.5"

#713

and should it be unpinned?

I think you could release v0.1.6 and pin that. I'm not totally against unpinning either, as the pyrenew entry in the lock file isn't automatically updated.

[cdc-mitzimorris]

why did this get pinned to "v0.1.5"

#713

and should it be unpinned?

I think you could release v0.1.6 and pin that. I'm not totally against unpinning either, as the pyrenew entry in the lock file isn't automatically updated.

I drafted a release "v0.1.6" @damonbayer does this look OK?

[damonbayer]

I drafted a release "v0.1.6" @damonbayer does this look OK?

I did one more commit to increment the version number CDCgov/PyRenew#626 and released it. Thanks!