-
Notifications
You must be signed in to change notification settings - Fork 3
Mem time redo #733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mem time redo #733
Conversation
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #733 +/- ##
==========================================
+ Coverage 26.08% 26.28% +0.20%
==========================================
Files 26 26
Lines 2427 2427
==========================================
+ Hits 633 638 +5
+ Misses 1794 1789 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
damonbayer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a few small suggestions.
Co-authored-by: Damon Bayer <[email protected]>
for more information, see https://pre-commit.ci
This PR adds more tests for pyrenew_hew's
PyrenewHEWDataclass.This is part 1 of a do-over of #709. It doesn't change any of the code in
pyrenew_hew_data.py, except to add a docstring for functionto_forecast_data. PR 709 made a breaking change to this function; the added documentation is intended prevent future mistakes.Part 2 of this do-over will use the functions in
PyRenew/pyrenew/time.py. specifically:align_observation_timescreate_date_time_spineget_end_dateget_n_data_daysvalidate_mmwr_dates,Currently, these are defined as methods in class
PyrewnewHEWData; part 2 will change the calls inPyrewnewHEWDatafromself.get_end_datetoget_end_date, etc.