SMART on FHIR pt 3 - frontend changes #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 59.41% (-0.05% 🔻) |
1720/2895 |
| 🔴 | Branches | 49.25% (-1.47% 🔻) |
493/1001 |
| 🟡 | Functions | 62.85% | 357/568 |
| 🔴 | Lines | 59.34% (-0.05% 🔻) |
1623/2735 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / fhir-servers.ts |
31.58% (-0.85% 🔻) |
13.21% (-11.79% 🔻) |
42.86% | 29.58% (-0.86% 🔻) |
Test suite run success
159 tests passing in 20 suites.
Report generated by 🧪jest coverage report action from 162ce15
fzhao99
force-pushed
the
nickclyde/smart-backend
branch
2 times, most recently
from
9268950 to
5ec83a0
Compare
fzhao99
force-pushed
the
nickclyde/smart-workflow-frontend
branch
from
52ad2e4 to
cb1b979
Compare
fzhao99
force-pushed
the
nickclyde/smart-backend
branch
2 times, most recently
from
9fce88a to
c4ff5ed
Compare
fzhao99
force-pushed
the
nickclyde/smart-workflow-frontend
branch
from
3356d77 to
cd089d6
Compare
…m/CDCgov/dibbs-query-connector into nickclyde/smart-workflow-frontend
fzhao99
requested review from
nickclyde,
akintner,
katyasoup and
robertandremitchell
nickclyde
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Part three of SMART on FHIR implementation that completes the SMART on FHIR work by implementing the frontend and adding an e2e test.
Related Issue
Follow up to #452 and fixes QUE-211
Authentication Enhancements:
This PR propagates the code in the previous backend / infra PR's into the frontend FHIR server modal. Users now have the ability to select / integrate SMART into their FHIR server setup experience