Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT User Group query filtering of saved queries #446

Closed
wants to merge 5 commits into from

Conversation

akintner
Copy link
Collaborator

PULL REQUEST

Summary

Now that user management includes groups, saved queries should filter based on the user's group and only display those for which a user has appropriate access.

##Fixes #436

Checklist

  • Descriptive Pull Request title
  • Link to relevant issues
  • Provide necessary context for design reviewers
  • Ensure test coverage is above agreed upon threshold
  • Update documentation

@akintner akintner changed the title User Group query filtering of saved queries DRAFT User Group query filtering of saved queries Mar 21, 2025
Copy link

github-actions bot commented Mar 21, 2025

Coverage report for ./query-connector

Caution

Test run failed

St.
Category Percentage Covered / Total
🔴 Statements
59.47% (+0.01% 🔼)
1720/2892
🔴 Branches 50.72% 491/968
🟡 Functions 62.85% 357/568
🔴 Lines
59.41% (+0.01% 🔼)
1623/2732

Test suite run failed

Failed tests: 4/163. Failed suites: 2/22.
  ● User Group and Query Membership Tests › should retrieve user group memberships

    error: syntax error at end of input

      39 | 
      40 |     `;
    > 41 |     await dbClient.query(insertUsersQuery, [TEST_USER_1_ID, TEST_USER_2_ID]);
         |     ^
      42 |
      43 |     // Insert test group
      44 |     const insertGroupQuery = `

      at node_modules/pg-pool/index.js:42:11
      at Object.<anonymous> (src/app/tests/integration/usergroup-query_filtering.test.ts:41:5)

  ● User Group and Query Membership Tests › should add multiple queries to a group

    error: syntax error at end of input

      39 | 
      40 |     `;
    > 41 |     await dbClient.query(insertUsersQuery, [TEST_USER_1_ID, TEST_USER_2_ID]);
         |     ^
      42 |
      43 |     // Insert test group
      44 |     const insertGroupQuery = `

      at node_modules/pg-pool/index.js:42:11
      at Object.<anonymous> (src/app/tests/integration/usergroup-query_filtering.test.ts:41:5)


  ● User Group and Query Membership Tests › should retrieve user group memberships

    error: syntax error at end of input

      39 | 
      40 |     `;
    > 41 |     await dbClient.query(insertUsersQuery, [TEST_USER_1_ID, TEST_USER_2_ID]);
         |     ^
      42 |
      43 |     // Insert test group
      44 |     const insertGroupQuery = `

      at node_modules/pg-pool/index.js:42:11
      at Object.<anonymous> (src/app/tests/integration/usergroup-queries.test.ts:41:5)

  ● User Group and Query Membership Tests › should add multiple queries to a group

    error: syntax error at end of input

      39 | 
      40 |     `;
    > 41 |     await dbClient.query(insertUsersQuery, [TEST_USER_1_ID, TEST_USER_2_ID]);
         |     ^
      42 |
      43 |     // Insert test group
      44 |     const insertGroupQuery = `

      at node_modules/pg-pool/index.js:42:11
      at Object.<anonymous> (src/app/tests/integration/usergroup-queries.test.ts:41:5)

Report generated by 🧪jest coverage report action from 46648f5

@akintner akintner force-pushed the kintner/team-queries branch from 69bcf0e to 96cdd34 Compare March 25, 2025 21:38
@akintner akintner force-pushed the kintner/team-queries branch from 3358026 to 551a419 Compare March 27, 2025 17:04
@akintner akintner force-pushed the kintner/team-queries branch from 70d9350 to 489e135 Compare March 28, 2025 15:55
@akintner akintner force-pushed the kintner/team-queries branch from 98f82ab to 4624c6c Compare March 28, 2025 16:01
@akintner akintner closed this Mar 28, 2025
@akintner akintner deleted the kintner/team-queries branch March 28, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only show queries attached to user's teams in query flow
1 participant