Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup of test accounts for admin and standard roles in local and dev env #443

Merged
merged 5 commits into from
Mar 20, 2025

Conversation

johanna-skylight
Copy link
Collaborator

@johanna-skylight johanna-skylight commented Mar 19, 2025

PULL REQUEST

Summary

This PR will create user accounts in keycloak and the respective entries in the users, groups and join tables to provide three more test users and two user groups.

Users
Princess Peach | peach | foo123! | Admin
Mario Mario | mario | foo123! | Standard
Captain Toad | toad | foo123! | Standard

Groups
Castle Team -> Peach and Mario
Mushroom Team -> Toad

Changes include:

  • Adds Peach, Mario and Toad to the keycloak seeding file for local and dev.
  • Updates the vs_dump.sql file to include the entries in all the tables related to user management.
  • Removed the logic that set the first logged in user as super admin.
  • Added migration to drop the user_management table that is no longer used.

Related Issue

Fixes QUE-202

Additional Information

I went with the Mario theme because the users were super easy to spell and remember :D.

Checklist

  • Descriptive Pull Request title
  • Link to relevant issues
  • Provide necessary context for design reviewers
  • Ensure test coverage is above agreed upon threshold
  • Update documentation

Sorry, something went wrong.

Copy link

linear bot commented Mar 19, 2025

Copy link

github-actions bot commented Mar 19, 2025

Coverage report for ./query-connector

St.
Category Percentage Covered / Total
🟡 Statements
62.89% (-0.07% 🔻)
1605/2552
🔴 Branches
53.05% (-0.11% 🔻)
452/852
🟡 Functions 63.99% 343/536
🟡 Lines
62.87% (-0.08% 🔻)
1500/2386
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / user-management.ts
69.29% (-1.06% 🔻)
41.03% (-2.88% 🔻)
86.67%
68.61% (-1.11% 🔻)

Test suite run success

156 tests passing in 20 suites.

Report generated by 🧪jest coverage report action from a60e1df

Copy link
Collaborator

@robertandremitchell robertandremitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@johanna-skylight johanna-skylight changed the title jd/202 setup test accounts for local an dev Setup of test accounts for admin and standard roles in local and dev env Mar 20, 2025
Copy link
Collaborator

@fzhao99 fzhao99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL mario's last name is mario

@johanna-skylight johanna-skylight merged commit 2c477fd into main Mar 20, 2025
12 checks passed
@johanna-skylight johanna-skylight deleted the jd/202-setup-test-accts branch March 20, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants