jd/implements automatic logout modal #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_modal merged with latest code in main
…_modal insert with latest main
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 62.96% (+0.51% 🔼) |
1610/2557 |
| 🔴 | Branches | 53.16% (+0.56% 🔼) |
454/854 |
| 🟡 | Functions | 63.99% (+0.61% 🔼) |
343/536 |
| 🟡 | Lines | 62.94% (+0.55% 🔼) |
1505/2391 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / sessionTimeout.tsx |
94.87% | 100% | 100% | 100% |
Test suite run success
156 tests passing in 20 suites.
Report generated by 🧪jest coverage report action from 4e69954
johanna-skylight
changed the title
johanna-skylight
requested review from
fzhao99,
nickclyde,
katyasoup and
robertandremitchell
robertandremitchell
approved these changes
Mar 19, 2025
fzhao99
approved these changes
Mar 19, 2025
nickclyde
approved these changes
Mar 19, 2025
There was a problem hiding this comment.
Thanks for this Johanna! One note - before you merge, can you change the pull request title to be a little more descriptive? Since we do squash merges by default, the PR title is what gets shown in the commit history of main, and it's helpful to be able to quickly identify commits!
johanna-skylight
changed the title
|
I have addressed UI/UX feedback and Michelle gave thumbs up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
This work implements the
SessionTimeoutcomponent which takes care of tracking authenticated user's idle periods and triggers an automatic sign-out.It also handles the logic to prompt the user with a modal which gives the opportunity to stay signed in or sign out on the spot.
Related Issue
Fixes QUE-201
Additional Information
In order to test the idle time you need to make sure that no mouse event is triggered or the timer will reset. Like seriously even moving the mouse counts. You could just adjust the idle time for a shorter period in your local
IDLE_TIMEOUT_MSECin the SessionTimeout file.Checklist