Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #219

Closed
wants to merge 3 commits into from

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Mar 17, 2025

updates:
- [github.com/lorenzwalthert/precommit: v0.4.3.9003 → v0.4.3.9007](lorenzwalthert/precommit@v0.4.3.9003...v0.4.3.9007)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 303a848 to 5d7a7ff Compare March 17, 2025 19:30
Copy link

github-actions bot commented Mar 17, 2025

Thank you for your contribution @micahwiesner67 🚀! Your pkgdown-site is ready for download 👉 here 👈!
(The artifact expires on 2025-03-31T18:43:37Z. You can re-generate it by re-running the workflow here.)

Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kgostic
Copy link
Collaborator

kgostic commented Mar 21, 2025

@zsusswein -- do we want this in the news.md?

@kgostic
Copy link
Collaborator

kgostic commented Mar 21, 2025

I also don't know that I agree we should remove the explicit returns it's flagging. Let's discuss on Monday!

@kgostic
Copy link
Collaborator

kgostic commented Mar 25, 2025

We decided to skip this update because we don't agree with implicit returns in all functions. We'll probably be forced to make a decision or pivot to air soon.

@kgostic kgostic closed this Mar 25, 2025
@micahwiesner67 micahwiesner67 deleted the pre-commit-ci-update-config branch March 25, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants