Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Phase-3" discussed in PR-#194 #214

Merged
merged 17 commits into from
Mar 25, 2025
Merged

"Phase-3" discussed in PR-#194 #214

merged 17 commits into from
Mar 25, 2025

Conversation

aisha-cdc
Copy link
Collaborator

"Phase 3" discussed in PR-#194 - Integrate dependencies image and main dockerfile.

Summary:

Changes made in Pull Request #194 were requested to be merged in phases

This PR implements Phase 3 -> Integrate dependencies image and main dockerfile.

Changes Introduced:

  • Re-implement branch and tag management steps from twostep-container-build action within containers-and-az-pool workflow.
  • Replace dependency image caching strategy of twostep-container-build with docker_build_and_push.sh
  • Integrate steps from main Dockerfile and Dockerfile-dependencies into Dockerfile.unified

Copy link

github-actions bot commented Mar 13, 2025

Thank you for your contribution @micahwiesner67 🚀! Your pkgdown-site is ready for download 👉 here 👈!
(The artifact expires on 2025-04-01T15:47:44Z. You can re-generate it by re-running the workflow here.)

Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@micahwiesner67 micahwiesner67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the merge conflicts in NEWS.md and containers-and-az-pool.yaml

@micahwiesner67
Copy link
Collaborator

micahwiesner67 commented Mar 14, 2025

I will wait to confirm stability of phase 1 / phase 2 before reviewing this. Converting to draft for now

@micahwiesner67 micahwiesner67 marked this pull request as draft March 14, 2025 21:11
@micahwiesner67 micahwiesner67 marked this pull request as ready for review March 24, 2025 19:42
@micahwiesner67
Copy link
Collaborator

It seems phase 1 and 2 have had no issues so I'm converting this back to an open PR instead of a draft. Lmk if it's ready for review @aisha-cdc and @giomrella

@giomrella
Copy link
Collaborator

It seems phase 1 and 2 have had no issues so I'm converting this back to an open PR instead of a draft. Lmk if it's ready for review @aisha-cdc and @giomrella

Looks good to me!

@micahwiesner67 micahwiesner67 merged commit d9c00b5 into main Mar 25, 2025
11 checks passed
@micahwiesner67 micahwiesner67 deleted the phase-3 branch March 25, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants