-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Phase-3" discussed in PR-#194 #214
Conversation
for more information, see https://pre-commit.ci
Thank you for your contribution @micahwiesner67 🚀! Your pkgdown-site is ready for download 👉 here 👈! |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the merge conflicts in NEWS.md and containers-and-az-pool.yaml
I will wait to confirm stability of phase 1 / phase 2 before reviewing this. Converting to draft for now |
It seems phase 1 and 2 have had no issues so I'm converting this back to an open PR instead of a draft. Lmk if it's ready for review @aisha-cdc and @giomrella |
Looks good to me! |
"Phase 3" discussed in PR-#194 - Integrate dependencies image and main dockerfile.
Summary:
Changes made in Pull Request #194 were requested to be merged in phases
This PR implements Phase 3 -> Integrate dependencies image and main dockerfile.
Changes Introduced:
twostep-container-build
action withincontainers-and-az-pool
workflow.twostep-container-build
withdocker_build_and_push.sh
Dockerfile
andDockerfile-dependencies
intoDockerfile.unified