-
Notifications
You must be signed in to change notification settings - Fork 1
Rr 65 add key vault #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds Azure Key Vault integration to the authentication system, allowing credentials and configuration to be loaded from Key Vault in addition to environment variables and .env files.
Key Changes:
- Added
keyvaultandforce_keyvaultparameters to all credential handler classes - Implemented new functions for retrieving and loading secrets from Azure Key Vault
- Updated
CloudClientto support Key Vault configuration with fallback logic
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| cfa/cloudops/auth.py | Added Key Vault support functions and integrated Key Vault loading into all credential handlers |
| cfa/cloudops/_cloudclient.py | Updated CloudClient initialization to accept and pass through Key Vault parameters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
docs/CloudClient/authentication.md:1
- Corrected spelling of 'setiing' to 'setting'.
# Authentication with `cfa.cloudops.CloudClient`
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.