Skip to content

Conversation

@ryanraaschCDC
Copy link
Collaborator

No description provided.

@ryanraaschCDC ryanraaschCDC requested a review from Copilot December 4, 2025 17:45
@ryanraaschCDC ryanraaschCDC self-assigned this Dec 4, 2025
@ryanraaschCDC ryanraaschCDC linked an issue Dec 4, 2025 that may be closed by this pull request
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Azure Key Vault integration to the authentication system, allowing credentials and configuration to be loaded from Key Vault in addition to environment variables and .env files.

Key Changes:

  • Added keyvault and force_keyvault parameters to all credential handler classes
  • Implemented new functions for retrieving and loading secrets from Azure Key Vault
  • Updated CloudClient to support Key Vault configuration with fallback logic

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.

File Description
cfa/cloudops/auth.py Added Key Vault support functions and integrated Key Vault loading into all credential handlers
cfa/cloudops/_cloudclient.py Updated CloudClient initialization to accept and pass through Key Vault parameters

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ryanraaschCDC ryanraaschCDC requested a review from Copilot December 4, 2025 22:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

docs/CloudClient/authentication.md:1

  • Corrected spelling of 'setiing' to 'setting'.
# Authentication with `cfa.cloudops.CloudClient`

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ryanraaschCDC ryanraaschCDC marked this pull request as ready for review December 12, 2025 15:13
@ryanraaschCDC ryanraaschCDC requested a review from xop5 December 12, 2025 15:13
@ryanraaschCDC ryanraaschCDC requested a review from xop5 January 6, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add azure key vault capabilities

3 participants