Refactor legend generation into modular helper functions #2275
+711
−455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Extract legend processing logic into separate helper modules * Add new helper files for category, equal number, and equal interval legend handling * Create legendUtils for common legend initialization and finalization * Add legendDataProcessing for data filtering and preparation * Update MapConfig type to include roundToPlace property for primary columns * Add comprehensive test file for generateRuntimeLegend * Improve type safety with better TypeScript definitions * Maintain backward compatibility while improving code organization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing Steps
Optional
Storybook Links
Screenshots