Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the get blocking data call to allow for some missing blocking values. If too many values are missing from the query (indicated by checking log odds values), then the blocking pass will be skipped.
Related Issues
closes #230
Additional Notes
A couple of things to note on the implementation.
kwargs
.get_block_data
was converted into a class,GetBlockData
. The Improve Evaluation of Missing Values epic has introduced extra conditions for retrieving blocking data. Checking for those extra conditions requires reusing variables, or at least benefits from reuse, thus storing some sort of state between the different functions has an advantage. There are some alternatives, that are worth considering, that I experimented with before landing on this solution. I think all three implementations can do a good job of encapsulating the logic and optimizing the looping constructs for efficient evaluation. If anyone thinks another implementation would read better, please voice that.<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: