Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing values in blocked MPI records #242

Merged
merged 2 commits into from
Mar 14, 2025

Conversation

bamader
Copy link
Collaborator

@bamader bamader commented Mar 10, 2025

Description

This PR adds a filter function to the get_block_data function in the mpi_service. This filter function removes from consideration all candidates from the MPI who are part of a person cluster containing a patient who satisfied blocking criteria, but which themselves have present values (i.e. are not missing fields) that disagree with incoming blocking keys. This will make matching more precise and reinforce validity in the blocking step.

Related Issues

#231

Additional Notes

N/A

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

Sorry, something went wrong.

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.80%. Comparing base (a2798c1) to head (3f7d80d).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
+ Coverage   97.72%   97.80%   +0.07%     
==========================================
  Files          32       33       +1     
  Lines        1674     1731      +57     
==========================================
+ Hits         1636     1693      +57     
  Misses         38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bamader bamader requested a review from ericbuckley March 13, 2025 20:41
@bamader bamader merged commit d680b2d into main Mar 14, 2025
15 checks passed
@bamader bamader deleted the exclude-incorrect-blocking branch March 14, 2025 12:45
bamader added a commit that referenced this pull request Mar 19, 2025
## Description
This PR adds a filter function to the `get_block_data` function in the
`mpi_service`. This filter function removes from consideration all
candidates from the MPI who are part of a person cluster containing a
patient who satisfied blocking criteria, but which themselves have
present values (i.e. are not missing fields) that disagree with incoming
blocking keys. This will make matching more precise and reinforce
validity in the blocking step.

## Related Issues
#231 

## Additional Notes
N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants