Make setting prometheus query interval minute configurable #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naved001
force-pushed
the
adjustable-metric-frequency
branch
2 times, most recently
from
f6b9469 to
65b80d7
Compare
Collaborator
Author
|
I have submitted #165 to refactor the "merge.py" script a bit to make it easier to add some tests and newer functionality, after that's merged I can redo this PR. |
jimmysway
reviewed
Nov 14, 2025
jimmysway
approved these changes
Nov 14, 2025
We have some clusters where we would like to change the frequency at which we collect metrics and generate the report based on that. To accomplish this, we need to make 2 changes. We set an environment variable that is passed on to the metrics collector scripts. And we insert the collection interval into the json file. The merge scripts will read this interval when loading these files. For backwards compatibility with our old metrics file, we'll default to 15 minutes when processing these files.
naved001
force-pushed
the
adjustable-metric-frequency
branch
from
65b80d7 to
7e9f94c
Compare
knikolla
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some clusters where we would like to change the frequency at which we collect metrics and generate the report based on that.
To accomplish this, we need to make 2 changes. We set an environment variable that is passed on to the metrics collector scripts. And we insert the collection interval into the json file.
The merge scripts will read this interval when loading these files. For backwards compatibility with our old metrics file, we'll default to 15 minutes when processing these files.
P.S. merge.py is getting a bit ugly so I am going to submit another PR that refactors some of the stuff and adds tests.