Consolidated config into constants, config with env files. #154
Conversation
|
I had a brief discussion with @naved001 pertaining to how we should structure all the hardcoded variables. I was going to do it bit by bit but that might have been confusing perhaps. I've found a lot of constants in the process of doing this and having one massive env file seems unwieldy so I've split it up into constants and config. There were also ideas of organizing things further with some sort of I think some documentation is probably needed in the future regarding these config variable This will probably subject to change as we make a decision on how we want to manage all our hardcoded values. |
jimmysway
force-pushed
the
fix/144-organizing-config
branch
from
4480a0f to
c472167
Compare
jimmysway
force-pushed
the
fix/144-organizing-config
branch
from
c472167 to
9f1b0be
Compare
There was a problem hiding this comment.
This PR does too much in one. I'd like to see smaller PRs that way they get reviewed quickly and don't sit for months.
We should start by having a PR that only manages a subset of the config - specifically the infrastructure config (S3 related config) to start with. That's the one that currently changes between various environments.
Addresses #144