Repository navigation
Allow oac-prod-infra to read an additional secret - #62
Merged
Merged
Conversation
This secret is necessary so that the cronjobs on oac-prod-infra can write metrics for oac-prod-workload0 to the b2 bucket.
naved001
force-pushed
the
oac-prod-infra/b2-secret
branch
from
October 27, 2026 14:51
f5695a8 to
d73ac52
Compare
naved001
changed the title
larsks
approved these changes
Oct 27, 2026
QuanMPhm
reviewed
Oct 27, 2026
| oidc_bucket_domain_name = aws_s3_bucket.oac_oidc.bucket_regional_domain_name | ||
| cert_manager_policy_arn = module.cert_manager_policy["cert_manager_policy_oac_prod_infra"].policy_arn | ||
| eso_readable_secret_prefixes = [ | ||
| "b2-key/oac-prod-workload0-rw", |
Contributor
There was a problem hiding this comment.
nitpick: isn't this secret read-only. And if yes, should it be ro instead of rw?
Contributor
Author
There was a problem hiding this comment.
The key should be rw I want my cronjob to be able to write to the bucket. It's a readable secret for ESO i.e. ESO can read this secret but not modify it which is why its eso_readable_secret.
QuanMPhm
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This secret is necessary so that the cronjobs on oac-prod-infra can write metrics for oac-prod-workload0 to the b2 bucket.