Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use datetime import correctly for _get_file_mtime() #21

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented Nov 26, 2024

Changes

this function was moved from RENEE but the import statement was not updated

it is only used when rerunning pipelines, so the error wasn't caught until now

Issues

NA

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • Write unit tests for any new features, bug fixes, or other code changes.
  • [ ] Update docs if there are any API changes.
  • Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/

@kelly-sovacool kelly-sovacool merged commit 91e12be into main Nov 26, 2024
6 checks passed
@kelly-sovacool kelly-sovacool deleted the mtime branch November 26, 2024 20:16
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.80%. Comparing base (c338de2) to head (c8cdfa3).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   31.56%   31.80%   +0.23%     
==========================================
  Files          17       17              
  Lines        1264     1264              
==========================================
+ Hits          399      402       +3     
+ Misses        865      862       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant