Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local modomics DB & upgrade to new FRCE modules #5

Merged
merged 17 commits into from
Nov 17, 2023

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented Oct 31, 2023

  • Add a mimseq_flags option to the config file and use the --local-modomics flag by default to fix mimseq KeyError: 'Ζ' not in modification table #1.
  • Use a Docker container built from a custom forked version of mimseq. This allows us to iterate faster so we don't have to wait on maintainers to merge our PRs when we fix bugs.
  • Use the newly upgraded singularity & snakemake modules on FRCE.

@kopardev kopardev added the TRANQUIL RepoName label Oct 31, 2023
kelly-sovacool added a commit to CCBR/.github that referenced this pull request Nov 8, 2023
otherwise, it runs the workflow every time there's _any_ activity on the issue, e.g. see CCBR/TRANQUIL#5
@kelly-sovacool kelly-sovacool marked this pull request as ready for review November 17, 2023 16:13
@kelly-sovacool kelly-sovacool merged commit 2b96d5d into master Nov 17, 2023
@kelly-sovacool kelly-sovacool deleted the mimseq-1.3.7 branch November 17, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TRANQUIL RepoName
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mimseq KeyError: 'Ζ' not in modification table
2 participants