CRDCDH 2161 #714
Merged
CRDCDH 2161 #714
+27
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
services/approved-studies.js
Outdated
| throw new Error(ERROR.INVALID_PRIMARY_CONTACT_ROLE); | ||
| let primaryContact = null; | ||
| if (!primaryContactID) { | ||
| const primaryContact = await this.#findUserByID(primaryContactID); |
There was a problem hiding this comment.
This wouldn't be ideal since primaryContact has already been declared as null.
let => const?
There was a problem hiding this comment.
It can't be const because it could be reassigned to what find by the primaryContactID. It will be add to return value.
There was a problem hiding this comment.
The value is changing let => const
Please, take a look at the line 293.
primaryContact = await this.#findUserByID(primaryContactID);
There was a problem hiding this comment.
Oh, updated, thanks!
AustinSMueller
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated based on changes in user story and task as listed below:
-Update createApprovedStudy and updateApprovedStudy APIs and make primaryContactID parameter optional
-Update ApprovedStudy GraphQL type and all APIs which returns that type and change program to programs and make is [UserOrganization]