Skip to content

Conversation

@KEEKE132
Copy link
Contributor

@KEEKE132 KEEKE132 commented Jan 4, 2026

🚩 관련사항

Close: #1033

📢 전달사항

datasource Proxy에서 쿼리가 2번 로깅, 측정되는 문제 발생

조사결과 스프링부트가 지정해주는 Listener와 Config로 직접 지정한 리스너 2개가 존재하여 중복 측정되었음
스프링부트가 설정해주는 Listener는 Default Listener뿐 아니라 직접 커스텀한 리스너도 포함되었음,
Config 파일을 제거하여 해결

📸 스크린샷

📃 진행사항

  • 버그 수정

⚙️ 기타사항

기타 참고사항을 적어주세요.

개발기간:

@github-actions github-actions bot added the D-4 label Jan 4, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @KEEKE132, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 datasource Proxy에서 발생하는 쿼리 중복 로깅 및 측정 문제를 해결하기 위한 변경사항입니다. 스프링 부트의 자동 설정과 수동 설정 간의 충돌로 인해 발생한 문제를 해결하기 위해 불필요한 설정 파일을 제거하여 시스템의 효율성과 정확성을 개선했습니다.

Highlights

  • 중복 로깅/측정 문제 해결: datasource Proxy에서 쿼리가 두 번 로깅되고 측정되는 문제를 해결했습니다. 이 문제는 스프링 부트가 제공하는 리스너와 DatasourceProxyConfig 파일에서 직접 정의한 리스너가 중복되어 발생했습니다.
  • DatasourceProxyConfig.java 파일 제거: 중복 리스너 문제를 해결하기 위해 DatasourceProxyConfig.java 파일을 제거했습니다. 스프링 부트가 이미 커스텀 리스너를 포함한 데이터 소스 설정을 처리하고 있었기 때문에, 이 파일은 더 이상 필요하지 않았습니다.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

이 PR은 datasource-proxy-spring-boot-starter의 자동 설정과 중복되는 수동 DataSource 프록시 설정을 제거하여 쿼리가 두 번 로깅되는 문제를 해결합니다. DatasourceProxyConfig.java 파일을 삭제하여 중복 리스너 등록을 방지한 것은 올바른 수정입니다. 변경 사항을 검토한 결과, 다른 문제는 발견되지 않았습니다.

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

Migration Result 📦

Status Count
✅ Success 27
❌ Failed 0
⏳ Pending 0

Schema Validation Result 🔍

✅ No schema mismatches detected.

Results for commit 84d76de

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

Test Results Summary

 54 files   54 suites   14s ⏱️
250 tests 250 ✅ 0 💤 0 ❌
288 runs  288 ✅ 0 💤 0 ❌

Results for commit 84d76de.

♻️ This comment has been updated with latest results.

@KEEKE132 KEEKE132 changed the title fix: Config 파일 삭제 fix: Datasource Proxy 쿼리 중복 측정 버그 수정 Jan 4, 2026
@bingle625 bingle625 merged commit 08b0c5e into dev Jan 4, 2026
6 checks passed
@bingle625 bingle625 deleted the fix/#1033/datasource-proxy-duplicate-query branch January 4, 2026 09:25
@bingle625 bingle625 restored the fix/#1033/datasource-proxy-duplicate-query branch January 4, 2026 09:25
@bingle625 bingle625 deleted the fix/#1033/datasource-proxy-duplicate-query branch January 4, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FIX] Datasource Proxy 쿼리 중복 측정 해결

3 participants