-
Notifications
You must be signed in to change notification settings - Fork 20
fix: Datasource Proxy 쿼리 중복 측정 버그 수정 #1034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @KEEKE132, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 datasource Proxy에서 발생하는 쿼리 중복 로깅 및 측정 문제를 해결하기 위한 변경사항입니다. 스프링 부트의 자동 설정과 수동 설정 간의 충돌로 인해 발생한 문제를 해결하기 위해 불필요한 설정 파일을 제거하여 시스템의 효율성과 정확성을 개선했습니다. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
이 PR은 datasource-proxy-spring-boot-starter의 자동 설정과 중복되는 수동 DataSource 프록시 설정을 제거하여 쿼리가 두 번 로깅되는 문제를 해결합니다. DatasourceProxyConfig.java 파일을 삭제하여 중복 리스너 등록을 방지한 것은 올바른 수정입니다. 변경 사항을 검토한 결과, 다른 문제는 발견되지 않았습니다.
Migration Result 📦
Schema Validation Result 🔍✅ No schema mismatches detected. Results for commit ♻️ This comment has been updated with latest results. |
Test Results Summary 54 files 54 suites 14s ⏱️ Results for commit 84d76de. ♻️ This comment has been updated with latest results. |
🚩 관련사항
Close: #1033
📢 전달사항
datasource Proxy에서 쿼리가 2번 로깅, 측정되는 문제 발생
조사결과 스프링부트가 지정해주는 Listener와 Config로 직접 지정한 리스너 2개가 존재하여 중복 측정되었음
스프링부트가 설정해주는 Listener는 Default Listener뿐 아니라 직접 커스텀한 리스너도 포함되었음,
Config 파일을 제거하여 해결
📸 스크린샷
📃 진행사항
⚙️ 기타사항
기타 참고사항을 적어주세요.
개발기간: