You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add New Cleaning function to forward-fill previously detected lease_field or lease_operator vals into subsequent null instances. Utilizes the 'options' context of cleaning functions to save previous vals found.
This solution will resolve the issues with Page 2 extracted fields IF we modify our Page 2 splitter to have multiple pages (all the pages for a given Page 2 instance) in each record.
@rtl9148 looks fine. One thing to consider is how we will process the documents in the correct order. I believe the current batch processing may send documents from the GCS buckets in an undetermined order. So if we process using the current OGRRE method, we wouldn't necessarily have lease-value-less documents following the correct lease value.
@rtl9148 looks fine. One thing to consider is how we will process the documents in the correct order. I believe the current batch processing may send documents from the GCS buckets in an undetermined order. So if we process using the current OGRRE method, we wouldn't necessarily have lease-value-less documents following the correct lease value.
Hey Mike,
I've been looking into this and I think it should not be an issue. I see that we when we upload a lot of records(like for uploading an entire record_group), we do some batch downloading of documents. The stack flow for this looks like:
_process_batch_documents() -> _process_one_batch() -> _prepare_document_for_batch()
In the last function _prepare_document_for_batch() , we download the entire record, convert it into some png files _convert_pdf_bytes_to_png_files(), and in that function it looks like we assign some order to those png files so when we recombine them, they are in the same order the original pdf files were in.
I guess to summarize, it is fine if the RECORDS in a record_group are processed in a random order, but the pages WITHIN a record will need to be processed in the same order they are in within the pdf and I believe we are doing that. I plan to test this though on some multi-page records with a separate backend PR in the staging environment to verify.
ahh OK that makes sense. thanks for clarifying @rtl9148
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add New Cleaning function to forward-fill previously detected lease_field or lease_operator vals into subsequent null instances. Utilizes the 'options' context of cleaning functions to save previous vals found.
This solution will resolve the issues with Page 2 extracted fields IF we modify our Page 2 splitter to have multiple pages (all the pages for a given Page 2 instance) in each record.
Issue: CATALOG-Historic-Records/orphaned-wells-ui#604