forked from robincornelius/libedssharp
-
Notifications
You must be signed in to change notification settings - Fork 89
[MIX][DOCS] Improving global documentation #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
c455e60
[DOCS] README rephrasing
reza0310 6abb5a6
[DOCS] Contributing guidelines first draft
reza0310 f86ca9d
[DOCS] Prettyfication of the contributing guidelines
reza0310 d095b9d
[DOCS] Cleaning the root a little
reza0310 4848452
[DOCS] README splitting and cleaning
reza0310 0bc9d1a
Merge branch 'main' into docs
reza0310 4e9f8b7
[DOCS] Images PATH correction
reza0310 1ae0cb7
[DOCS] Corrections
reza0310 d98cb82
[DOCS] Explanation of the projects of the repository
reza0310 1e92795
[DOCS] Global list of available formats
reza0310 f1b8548
[DOCS][ACTION] YAML action for automatic contributor's list
reza0310 303af02
[ROOT][DOCS] contrib-readme-action has updated readme
github-actions[bot] 1908198
[DOCS] Better explanation and sorting of exporters
reza0310 9fe4311
[ROOT][DOCS] contrib-readme-action has updated readme
github-actions[bot] fb57d89
Merge branch 'CANopenNode:main' into docs
reza0310 108ca55
[DOCS] Usage
reza0310 0750ecd
[DOCS] Added pictures
reza0310 7d47d32
[DOCS] Images rendering path update
reza0310 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| # CANopenEditor Contributing Guidelines | ||
|
|
||
| Thank you for your interest in contributing to this project!<br> | ||
| Being a well referenced EDS/DCF editor and the only one supporting CANopenNode, CANopenEditor let everyone manage CANopen files, completely free of charge!<br> | ||
| CANopenEditor is maintained by a small team of volunteers from around the world. As such, those rules are meant for a better communication between everyone but, any help being very welcome, reviewers might approve PRs not respecting all of these rules as long as you tried. Project owners are above those rules as they might have specific needs.<br> | ||
| Please note that by contributing to this project, you agree to have read this file and to the [Developer's Certificate of Origin 1.1](https://developercertificate.org/). | ||
|
|
||
| ## Discussions | ||
| Discussions shall be done in respect to everyone and everyone's work. | ||
| Any major change shall be first discussed in an issue. Do not worry: maintainers are quite active and will answer. | ||
|
|
||
| ## Code convention | ||
| This project doesn't really follow any real code convention and doesn't have any linter for now BUT following [common C# code conventions](https://learn.microsoft.com/en-us/dotnet/csharp/fundamentals/coding-style/coding-conventions) is very welcome and might be asked of you if some parts of your code are too hard to read. | ||
| If linting is ever needed, `dotnet format` will be our solution of choice. | ||
| Even tho there is no hard-defined conventions, non-explicit names or lack of spacing might result in non-approval of a PR. | ||
|
|
||
| ## What might or might not be a PR | ||
| A simple refactor of code without any real change won't ever be approved. This project relies quite a bit on git blame and as such you are only allowed to refactor code you change. Moreover, trying to enforce a code convention without approval of the main maintainers first might be seen as disrespectful. | ||
|
|
||
| ## Testing | ||
| Any code change shall be tested. You can: | ||
| - Add unit tests in the right directories | ||
| - Describe any tests you did with the files you might have used | ||
|
|
||
| Code that you didn't even try to compile won't be accepted. | ||
|
|
||
| ## Code comments | ||
| - Complex algorithms MUST be explained with code comments. | ||
| - Hardcoded values (e.g. specific numbers in the middle of nowhere) MUST be justified with code comments. | ||
| - Non explicit data structures (e.g. an array of set size with every index having a meaning) MUST be explained with code comments. | ||
| - Commented lines of code MUST be preceded by a comment line starting with either `//// DEBUG code:` or `//// TODO:`. | ||
| - Comments SHALL have a space between the comment string (e.g. `//`) and the text content. | ||
| - Functions and methods MIGHT have comments describing what they are doing, what are their inputs and/or outputs (if it's not explicit enough). | ||
| - Loops and switches MIGHT have comments justifying why every case is taken into account (if it's not explicit enough). | ||
| - Any more useful comment is welcome. | ||
|
|
||
| ## Names and descriptions | ||
| ### PR names | ||
| They shall be composed of three sections: | ||
| 1) Which project is affected (MIX if multiple) | ||
| 2) What types of changes are made (e.g. FEAT, FIX, DOCUMENTATION/DOC, CORRECTION/CORR, SUGGESTION/SUGG, BUILD, ...) | ||
| 3) An explicit but less than 100 chars long summary of the changes | ||
|
|
||
| Sections shall be clearly separated (e.g. with colons, parenthesis, ...).<br> | ||
| Examples of valid and explicit PR names: `[MIX][DOC] Explaining explicit PR title rules`, `gui2: fix: Fixed bug where 1 = 2`.<br> | ||
| If you have multiple unrelated changes (e.g. adding a feature and fixing another) to do, please do multiple PRs. | ||
|
|
||
| ### PR descriptions | ||
| They shall: | ||
| - Describe any change made | ||
| - Explain why such changes are made | ||
| - Explain any decision taken | ||
| - Link any related issue / any related other PR | ||
| - Describe any test made | ||
| - The sentence "I have read the contributing guidelines, I agree to following them and I agree to the Developer's Certificate of Origin 1.1" | ||
|
|
||
| ### Commits | ||
| Names shall be composed of: | ||
| 1) What types of changes are made (e.g. PR names sections 2) | ||
| 2) An explicit but less than 100 chars long summary of the changes | ||
|
|
||
| Descriptions are entirely up to you. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.