edssharp: use the basename of the argv0 for the usage output#178
Merged
nimrof merged 1 commit intoCANopenNode:mainfrom Mar 21, 2025
Merged
Conversation
nimrof
requested changes
Mar 21, 2025
Collaborator
nimrof
left a comment
nimrof
left a comment
There was a problem hiding this comment.
Nice and thanks again.
Just one little thing:
Could you switch to String interpolation
The code was hardcoded to EDSEditor but the compiled code was
EDSSharp and so just cleanup the code to handle that case
Before:
Usage: EDSEditor --infile file.[xdd|eds] --outfile [valid output file] \
[OPTIONAL] --type [exporter type]
After:
Usage: EDSSharp --infile file.[xdd|eds] --outfile [valid output file] \
[OPTIONAL] --type [exporter type]
Signed-off-by: Charles Hardin <[email protected]>
ckhardin
force-pushed
the
ckhardin/edssharp-basename-usage
branch
from
578c7a1 to
a3f1a48
Compare
nimrof
approved these changes
Mar 21, 2025
Collaborator
nimrof
left a comment
nimrof
left a comment
There was a problem hiding this comment.
Thanks for the clean looking pr.!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code was hardcoded to EDSEditor but the compiled code was EDSSharp and so just cleanup the code to handle that case
Before:
After: