Conversation
abhaasgoyal
force-pushed
the
3-model-output-endpoint
branch
from
31a3622 to
0c944eb
Compare
bschroeter
requested changes
Apr 15, 2025
Contributor
bschroeter
left a comment
bschroeter
left a comment
There was a problem hiding this comment.
A few small things as indicated in the comments, most of them around the semantics of how things are currently named etc. This is mostly about future-proofing what we have and making it easier to enhance the client going forward.
Some other things that would be useful here:
- Update the docs to include details about how to use the new endpoint(s)
- More comprehensive tests, beyond just ensuring that a command doesn't return non-zero, but then using other parts of the client to ensure that what was created can indeed be returned as expected.
Nice work.
bschroeter
requested changes
Apr 16, 2025
bschroeter
approved these changes
Apr 22, 2025
Contributor
bschroeter
left a comment
bschroeter
left a comment
There was a problem hiding this comment.
A few small suggestions, but in the interest of closing this PR we can shunt them to another issue.
Nice work.
Add API Spec v2.1.0
abhaasgoyal
force-pushed
the
3-model-output-endpoint
branch
from
e5e8f5f to
1a200ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #63
Implement endpoint for creating a new model output (
POSTmethod) for a given Experiment ID + Model Profile IDAdd Github secrets for the following (following from the existing model output id)
MEORG_MODEL_OUTPUT_NAME- If no environment variable is provided forpytest,"meorg-client-model-output"is usedMEORG_MODEL_PROFILE_IDMEORG_EXPERIMENT_ID