Merged
Conversation
Contributor
Author
|
@JhanSrbinovsky sorry for pinging you again, just want to get this one fixed sooner rather than later. |
Collaborator
|
no problem. I've been distracted lately. I don't have a problem with reverting these - are you saying that your automated change of "!$" entered a binary file? |
JhanSrbinovsky
approved these changes
Jan 15, 2026
Contributor
Author
|
Seems so. The precise command I did was but I should've restricted the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CABLE
Thank you for submitting a pull request to the CABLE Project.
Description
@JhanSrbinovsky that PR I sent through yesterday accidentally caught the NC files we have in
src/offline- I guess there were some byte sequences that matched the regex I used to find and replace.📚 Documentation preview 📚: https://cable--673.org.readthedocs.build/en/673/