Skip to content

Revert changes to NC files#673

Merged
Whyborn merged 1 commit intomainfrom
fix-unintentional-nc-file-changes
Jan 15, 2026
Merged

Revert changes to NC files#673
Whyborn merged 1 commit intomainfrom
fix-unintentional-nc-file-changes

Conversation

@Whyborn
Copy link
Contributor

@Whyborn Whyborn commented Jan 13, 2026

CABLE

Thank you for submitting a pull request to the CABLE Project.

Description

@JhanSrbinovsky that PR I sent through yesterday accidentally caught the NC files we have in src/offline- I guess there were some byte sequences that matched the regex I used to find and replace.


📚 Documentation preview 📚: https://cable--673.org.readthedocs.build/en/673/

@Whyborn
Copy link
Contributor Author

Whyborn commented Jan 15, 2026

@JhanSrbinovsky sorry for pinging you again, just want to get this one fixed sooner rather than later.

@JhanSrbinovsky
Copy link
Collaborator

no problem. I've been distracted lately. I don't have a problem with reverting these - are you saying that your automated change of "!$" entered a binary file?

@Whyborn
Copy link
Contributor Author

Whyborn commented Jan 15, 2026

Seems so. The precise command I did was

find . -type f -exec perl -pi -e 's/!\$(?!OMP)/!/g' {} +

but I should've restricted the find to files ending in .F90

@Whyborn Whyborn merged commit b2d3f8d into main Jan 15, 2026
5 checks passed
@Whyborn Whyborn deleted the fix-unintentional-nc-file-changes branch January 15, 2026 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants