Skip to content

Remove unused ktau from biogeochem #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Whyborn wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove unused ktau from biogeochem #669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc2a546
Remove unused ktau variable from biogeochem
Whyborn Jan 8, 2026
59fd0df
Remove ktau from biogeochem body
Whyborn Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/offline/CASAONLY_LUC.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ SUBROUTINE CASAONLY_LUC( dels,kstart,kend,veg,soil,casabiome,casapool, &
climate%qtemp_max_last_year(:) = casamet%mtempspin(:,idoy)


CALL biogeochem(ktau,dels,idoy,LALLOC,veg,soil,casabiome,casapool,casaflux, &
CALL biogeochem(dels,idoy,LALLOC,veg,soil,casabiome,casapool,casaflux, &
casamet,casabal,phen,POP,climate,xnplimit,xkNlimiting,xklitter, &
xksoil,xkleaf,xkleafcold,xkleafdry,&
cleaf2met,cleaf2str,croot2met,croot2str,cwood2cwd, &
Expand Down
2 changes: 1 addition & 1 deletion src/offline/cable_mpimaster.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8265,7 +8265,7 @@ SUBROUTINE master_CASAONLY_LUC( dels,kstart,kend,veg,casabiome,casapool, &
!$ ! zero annual sums
!$ if (idoy==1) CALL casa_cnpflux(casaflux,casapool,casabal,.TRUE.)

!$ CALL biogeochem(ktau,dels,idoy,LALLOC,veg,soil,casabiome,casapool,casaflux, &
!$ CALL biogeochem(dels,idoy,LALLOC,veg,soil,casabiome,casapool,casaflux, &
!$ casamet,casabal,phen,POP,climate,xnplimit,xkNlimiting,xklitter, &
!$ xksoil,xkleaf,xkleafcold,xkleafdry,&
!$ cleaf2met,cleaf2str,croot2met,croot2str,cwood2cwd, &
Expand Down
6 changes: 3 additions & 3 deletions src/offline/cable_mpiworker.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7042,7 +7042,7 @@ SUBROUTINE worker_spincasacnp( dels,kstart,kend,mloop,veg,soil,casabiome,casapoo
DO idoy=1,mdyear
ktau=(idoy-1)*ktauday +1
CALL MPI_Recv (MPI_BOTTOM, 1, casa_dump_t, 0, idoy, icomm, stat, ierr)
CALL biogeochem(ktau,dels,idoy,LALLOC,veg,soil,casabiome,casapool,casaflux, &
CALL biogeochem(dels,idoy,LALLOC,veg,soil,casabiome,casapool,casaflux, &
casamet,casabal,phen,POP,climate,xnplimit,xkNlimiting,xklitter, &
xksoil,xkleaf,xkleafcold,xkleafdry,&
cleaf2met,cleaf2str,croot2met,croot2str,cwood2cwd, &
Expand Down Expand Up @@ -7210,7 +7210,7 @@ SUBROUTINE worker_spincasacnp( dels,kstart,kend,mloop,veg,soil,casabiome,casapoo
ktau=(idoy-1)*ktauday +1
CALL MPI_Recv (MPI_BOTTOM, 1, casa_dump_t, 0, idoy, icomm, stat, ierr)

CALL biogeochem(ktauy,dels,idoy,LALLOC,veg,soil,casabiome,casapool,casaflux, &
CALL biogeochem(dels,idoy,LALLOC,veg,soil,casabiome,casapool,casaflux, &
casamet,casabal,phen,POP,climate,xnplimit,xkNlimiting,xklitter,xksoil,xkleaf,&
xkleafcold,xkleafdry,&
cleaf2met,cleaf2str,croot2met,croot2str,cwood2cwd, &
Expand Down Expand Up @@ -7332,7 +7332,7 @@ SUBROUTINE worker_CASAONLY_LUC( dels,kstart,kend,veg,soil,casabiome,casapool, &
CALL MPI_Recv (MPI_BOTTOM, 1, casa_dump_t, 0, idoy, icomm, stat, ierr)


CALL biogeochem(ktau,dels,idoy,LALLOC,veg,soil,casabiome,casapool,casaflux, &
CALL biogeochem(dels,idoy,LALLOC,veg,soil,casabiome,casapool,casaflux, &
casamet,casabal,phen,POP,climate,xnplimit,xkNlimiting,xklitter, &
xksoil,xkleaf,xkleafcold,xkleafdry,&
cleaf2met,cleaf2str,croot2met,croot2str,cwood2cwd, &
Expand Down
4 changes: 2 additions & 2 deletions src/offline/spincasacnp.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ SUBROUTINE spincasacnp( dels,kstart,kend,mloop,veg,soil,casabiome,casapool, &
ENDIF
! write(6699,*) casaflux%cgpp(1), climate%mtemp(1), casaflux%crmplant(1,1)

CALL biogeochem(ktau,dels,idoy,LALLOC,veg,soil,casabiome,casapool,casaflux, &
CALL biogeochem(dels,idoy,LALLOC,veg,soil,casabiome,casapool,casaflux, &
casamet,casabal,phen,POP,climate,xnplimit,xkNlimiting,xklitter, &
xksoil,xkleaf,xkleafcold,xkleafdry,&
cleaf2met,cleaf2str,croot2met,croot2str,cwood2cwd, &
Expand Down Expand Up @@ -376,7 +376,7 @@ SUBROUTINE spincasacnp( dels,kstart,kend,mloop,veg,soil,casabiome,casapool, &



CALL biogeochem(ktauy,dels,idoy,LALLOC,veg,soil,casabiome,casapool,casaflux, &
CALL biogeochem(dels,idoy,LALLOC,veg,soil,casabiome,casapool,casaflux, &
casamet,casabal,phen,POP,climate,xnplimit,xkNlimiting,xklitter,xksoil,xkleaf,&
xkleafcold,xkleafdry,&
cleaf2met,cleaf2str,croot2met,croot2str,cwood2cwd, &
Expand Down
4 changes: 2 additions & 2 deletions src/science/casa-cnp/bgcdriver.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ SUBROUTINE bgcdriver(ktau,kstart,kend,dels,met,ssnow,canopy,veg,soil, &
ENDIF
# endif

CALL biogeochem(ktau,dels,idoy,LALLOC,veg,soil,casabiome,casapool,casaflux, &
CALL biogeochem(dels,idoy,LALLOC,veg,soil,casabiome,casapool,casaflux, &
casamet,casabal,phen,POP,climate, xnplimit,xkNlimiting,xklitter,xksoil, &
xkleaf,xkleafcold,xkleafdry,&
cleaf2met,cleaf2str,croot2met,croot2str,cwood2cwd, &
Expand Down Expand Up @@ -146,7 +146,7 @@ SUBROUTINE bgcdriver(ktau,kstart,kend,dels,met,ssnow,canopy,veg,soil, &

IF( MOD((ktau-kstart+1),ktauday) == 0 ) THEN ! end of day

CALL biogeochem(ktau,dels,idoy,LALLOC,veg,soil,casabiome,casapool,casaflux, &
CALL biogeochem(dels,idoy,LALLOC,veg,soil,casabiome,casapool,casaflux, &
casamet,casabal,phen,POP,climate,xnplimit,xkNlimiting,xklitter,xksoil,xkleaf, &
xkleafcold,xkleafdry,&
cleaf2met,cleaf2str,croot2met,croot2str,cwood2cwd, &
Expand Down
3 changes: 1 addition & 2 deletions src/science/casa-cnp/biogeochem_casa.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ MODULE biogeochem_mod

CONTAINS

SUBROUTINE biogeochem(ktau,dels,idoY,LALLOC,veg,soil,casabiome,casapool,casaflux, &
SUBROUTINE biogeochem(dels,idoY,LALLOC,veg,soil,casabiome,casapool,casaflux, &
casamet,casabal,phen,POP,climate,xnplimit,xkNlimiting,xklitter,xksoil,xkleaf,xkleafcold,xkleafdry,&
cleaf2met,cleaf2str,croot2met,croot2str,cwood2cwd, &
nleaf2met,nleaf2str,nroot2met,nroot2str,nwood2cwd, &
Expand All @@ -18,7 +18,6 @@ SUBROUTINE biogeochem(ktau,dels,idoY,LALLOC,veg,soil,casabiome,casapool,casaflux
USE casa_rplant_module, ONLY: casa_rplant

IMPLICIT NONE
INTEGER, INTENT(IN) :: ktau
REAL, INTENT(IN) :: dels
INTEGER, INTENT(IN) :: idoy
INTEGER, INTENT(IN) :: LALLOC
Expand Down