Closed
Conversation
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:
For more detailed information please look at CI in the EXCLAIM universe. |
msimberg
changed the title
Merged
jcanton
added a commit
that referenced
this pull request
Jan 5, 2026
Based upon #953 #954 and #957 by @msimberg Adds torus support to geometry, RBF and interpolation. Also adds torus grids to all datatests --------- Co-authored-by: Mikael Simberg <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of #954. Best viewed as diff: msimberg/icon4py@better-torus-support-interpolation...msimberg:icon4py:better-torus-support-metrics.
This is (so far) only updating tests, though some calculations may need updating as well.
I've marked two tests xfail in
test_metrics_factory.py. I have not investigated why they're wrong.A couple of tests in
test_metric_fields.py(test_compute_theta_exner_ref_mcandtest_compute_pressure_gradient_downward_extrapolation_mask_distance) fail for all grids (not just torus). Perhaps this is fixed on main already, but I'm not marking those xfail.