Fix return types in RBF interpolation functions#880
Merged
Conversation
Contributor
Author
|
cscs-ci run default |
egparedes
reviewed
Sep 22, 2025
Contributor
egparedes
left a comment
There was a problem hiding this comment.
A couple of comments for discussion.
model/common/src/icon4py/model/common/interpolation/rbf_interpolation.py
Outdated
Show resolved
Hide resolved
model/common/src/icon4py/model/common/interpolation/rbf_interpolation.py
Outdated
Show resolved
Hide resolved
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:
For more detailed information please look at CI in the EXCLAIM universe. |
halungge
approved these changes
Oct 7, 2025
Contributor
halungge
left a comment
There was a problem hiding this comment.
I have nothing more to add.
Contributor
Author
|
cscs-ci run default |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#871 made a partial fix, but the types still ended up slightly inconsistent. The generic
_compute_rbf_interpolation_coeffsreturns a dynamically sized list of ndarrays, as it depends on a dynamically sized list as input. The return type was incorrectly specified as a two-element tuple (it can be one or two elements long). #871 correctly made sure the cell/vertex-specific functions return a tuple, but with_compute_rbf_interpolation_coeffsreturning a list, the return values should be explicitly converted in those functions instead. This PR changes all uses of lists to tuples instead.