Skip to content

Fix return types in RBF interpolation functions#880

Merged
msimberg merged 2 commits intoC2SM:mainfrom
msimberg:fix-rbf-return-types
Oct 10, 2025
Merged

Fix return types in RBF interpolation functions#880
msimberg merged 2 commits intoC2SM:mainfrom
msimberg:fix-rbf-return-types

Conversation

@msimberg
Copy link
Copy Markdown
Contributor

@msimberg msimberg commented Sep 22, 2025

#871 made a partial fix, but the types still ended up slightly inconsistent. The generic _compute_rbf_interpolation_coeffs returns a dynamically sized list of ndarrays, as it depends on a dynamically sized list as input. The return type was incorrectly specified as a two-element tuple (it can be one or two elements long). #871 correctly made sure the cell/vertex-specific functions return a tuple, but with _compute_rbf_interpolation_coeffs returning a list, the return values should be explicitly converted in those functions instead. This PR changes all uses of lists to tuples instead.

@msimberg msimberg requested a review from halungge September 22, 2025 07:53
@msimberg
Copy link
Copy Markdown
Contributor Author

cscs-ci run default

Copy link
Copy Markdown
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments for discussion.

@github-actions
Copy link
Copy Markdown

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark-bencher

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:

  • cscs-ci run extra

For more detailed information please look at CI in the EXCLAIM universe.

Copy link
Copy Markdown
Contributor

@halungge halungge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have nothing more to add.

@msimberg
Copy link
Copy Markdown
Contributor Author

msimberg commented Oct 9, 2025

cscs-ci run default

@msimberg msimberg merged commit 5ae8e46 into C2SM:main Oct 10, 2025
47 checks passed
@msimberg msimberg deleted the fix-rbf-return-types branch October 10, 2025 08:42
jcanton added a commit that referenced this pull request Oct 14, 2025
* main:
  Script for blueline performance plot (#893)
  Fix return types in RBF interpolation functions (#880)
  Disabled DaCe `LoopBlocking` by Default (#895)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants