Conversation
Co-authored-by: Hannes Vogt <[email protected]>
muellch
left a comment
muellch
left a comment
There was a problem hiding this comment.
Looks good, I left one suggestion to improve variable names.
|
|
||
| # Create separate fields for the two components of the RBF vector coefficients and swap. | ||
| # TODO(havogt): we could use GT4Py's named collections. | ||
| rbf_coeff_1 = gtx.as_field( |
There was a problem hiding this comment.
I guess we should rename those from rbf_coeff_1 to rbf_vec_coeff_v_1 or rbf_coeff_v_1 so it is clear it is the vertex coefficients. There are also edge and cell coeffs ...
There was a problem hiding this comment.
We could also do this later, now these names are icon4py internal?
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:
For more detailed information please look at CI in the EXCLAIM universe. |
…#1119) Combines #1118 and #1115, because both require `v3` serialized data: - Move computation of `vertoffset_gradp` from `vertidx_gradp` to Python (index2offset) - Move transpose (and decomposition) of `rbf_vec_coeff_v` and `rbf_vec_coeff_e` to Python Additional: - Add missing halo exchange to `compute_zdiff_gradp` (test failure triggered by new serialized data, most likely unrelated to the other changes) - Refactor `kflip_wgtfacq` to a more general `flip` on fields
|
merged in #1119 |
2 participants
Needs updated serialized data. See https://github.com/C2SM/icon-exclaim/pull/428