Adapt type hints (and ignores) to gt4py#2484#1096
Draft
Conversation
4 tasks
Contributor
Author
|
cscs-ci run default |
Contributor
Author
|
cscs-ci run distributed |
Contributor
Author
|
cscs-ci run default |
Contributor
Author
|
cscs-ci run distributed |
DropD
added a commit
to GridTools/gt4py
that referenced
this pull request
Mar 17, 2026
## Description Partner-PR in icon4py: C2SM/icon4py#1096 (make sure this passes tests first) Radically reduce the amount of required type ignores in client code which uses the `from gt4py import next as gtx` pattern. Add a mypy plugin, which (when used) can also remove false positives for `Field[Dims[SomeDim], ...]`, where 'SomeDim' is an **instance** of `Dimension` (as mandated by gt4py), as well as false positives for missing binary ops between `float64` and `float` fields / scalars. - fixes #2496 - fixes #2503 Experimenting with this in icon4py reveals more ways in which gt4py blocks client code type checking, which have not been addressed in this PR so far: - [x] #2507 - [x] subtly different versions of #2507 where mypy reports a mismatch in dtypes, which have not been looked into further so far ## Requirements - [X] All fixes and/or new features come with corresponding tests. - [X] Important design decisions have been documented in the appropriate ADR inside the [docs/development/ADRs/](docs/development/ADRs/README.md) folder. --------- Co-authored-by: Enrique González Paredes <enriqueg@cscs.ch>
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:
For more detailed information please look at CI in the EXCLAIM universe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce blanket type ignores at the price of adding a handful specific ones.