Skip to content

fix wrong graupel tuning parameter config in data test #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OngChia wants to merge 9 commits into
base: main
Choose a base branch
from
Open

fix wrong graupel tuning parameter config in data test #1075

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a108dc1
fix wrong graupel tuning parameter config in data test
OngChia Feb 23, 2026
4ba05e2
review edit
OngChia Feb 23, 2026
ad39c68
Merge branch 'main' into fix_graupel_test
OngChia Feb 23, 2026
e01367c
try to fix wrong type in graupel config
OngChia Feb 23, 2026
c8f0021
first version of namelist_reader
jcanton Feb 23, 2026
0f13ca0
Merge branch 'main' into fix_graupel_test
OngChia Feb 23, 2026
200ac17
remove value from LiquidAutoConversionType and SnowInterceptParameter…
OngChia Feb 24, 2026
f24fb9b
trying to construct config from namelist
OngChia Feb 25, 2026
de5ef7a
trying f90nml and make config in fixture
OngChia Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...del/atmosphere/subgrid_scale_physics/microphysics/single_moment_six_class_gscp_graupel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class SingleMomentSixClassIconGraupelConfig:
#: Whether a fixed latent heat capacities are used for water. Originally defined as ithermo_water in mo_nwp_tuning_config.f90 in ICON (0 means True).
use_constant_latent_heat = True
#: First parameter in RHS of eq. 5.163 in the COSMO microphysics documentation for the sticking efficiency when lstickeff = True (repricated in icon4py because it is always True in ICON). Originally defined as tune_zceff_min in mo_tuning_nwp_config.f90 in ICON.
ice_stickeff_min: ta.wpfloat = 0.075
ice_stickeff_min: ta.wpfloat = 0.01
#: Power law coefficient in v-qi ice terminal velocity-mixing ratio relationship, see eq. 5.169 in the COSMO microphysics documentation. Originally defined as tune_zvz0i in mo_tuning_nwp_config.f90 in ICON.
power_law_coeff_for_ice_mean_fall_speed: ta.wpfloat = 1.25
#: Exponent of the density factor in ice terminal velocity equation to account for density (air thermodynamic state) change. Originally defined as tune_icesedi_exp in mo_tuning_nwp_config.f90 in ICON.
Expand Down
2 changes: 1 addition & 1 deletion ...y/model/atmosphere/subgrid_scale_physics/microphysics/stencils/microphyiscal_processes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@

@gtx.field_operator
def compute_cooper_inp_concentration(temperature: ta.wpfloat) -> ta.wpfloat:
cnin = 5.0 * exp(0.304 * (_phy_const.tmelt - temperature))
cnin = wpfloat("5.0") * exp(wpfloat("0.304") * (_phy_const.tmelt - temperature))
cnin = minimum(cnin, _microphy_const.NIMAX_THOM)
return cnin

Expand Down
9 changes: 1 addition & 8 deletions ...physics/tests/microphysics/integration_tests/test_single_moment_six_class_gscp_graupel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ def test_graupel(
lowest_layer_thickness: ta.wpfloat,
backend: gtx_typing.Backend,
):
pytest.xfail("Tolerances have increased with new ser_data, need to check with @ongchia")
vertical_config = v_grid.VerticalGridConfig(
icon_grid.num_levels,
lowest_layer_thickness=lowest_layer_thickness,
Expand Down Expand Up @@ -105,13 +104,7 @@ def test_graupel(

graupel_config = graupel.SingleMomentSixClassIconGraupelConfig(
liquid_autoconversion_option=mphys_options.LiquidAutoConversionType.SEIFERT_BEHENG,
ice_stickeff_min=0.01,
power_law_coeff_for_ice_mean_fall_speed=1.25,
exponent_for_density_factor_in_ice_sedimentation=0.3,
power_law_coeff_for_snow_fall_speed=20.0,
rain_mu=0.0,
rain_n0=1.0,
snow2graupel_riming_coeff=0.5,
ice_stickeff_min=0.075,
Copy link
Contributor

@jcanton jcanton Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't hardcode values in the middle of the test. Move to definitions.py where all other experiments coefficients are defined. Add a construct_mycrophisics_config method maybe?

Copy link
Contributor Author

@OngChia OngChia Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know many config is summarized in one place in definitions.py, and I think this microphysics config may be (a big question mark??) used again in the driver test . But it looks like it is still not very nice at all, it seems to me that we hardcode at another place. Similarly for VerticalGridConfig, this is kind of hardcoded everywhere... Possibly have to wait until we serialize namelist parameters and read them and generate config automatically somewhere.

Copy link
Contributor

@jcanton jcanton Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are serialized, I've added all NAMELIST_* files to serialized data, if you want you can start writing a reader for that and take them from there instead of hardcoding new stuff ;-)

)

graupel_microphysics = graupel.SingleMomentSixClassIconGraupel(
Expand Down