Update configure-ci-cd.md #413
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few tweaks here to update github action **Update actions to supported versions** ``` actionlint .github/workflows/hypernode-deploy.yml .github/workflows/hypernode-deploy.yml:16:15: the runner of "actions/checkout@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue [action] | 16 | - uses: actions/checkout@v2 | ^~~~~~~~~~~~~~~~~~~ .github/workflows/hypernode-deploy.yml:17:15: the runner of "actions/cache@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue [action] | 17 | - uses: actions/cache@v2 | ^~~~~~~~~~~~~~~~ ``` https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ **Add a retention limit to the deploy artifact** To keep storage costs under control **Add `run-name` for variable name This allows us to see which specific branch triggered the deployment from within the github actions UI
tdgroot
reviewed
Oct 2, 2025
There was a problem hiding this comment.
Thanks for your contribution! Some nice improvements altogether :).
While we're at it, could you update the actions so they use the latest versions? For example:
actions/checkouthas v5actions/cachehas v4actions/download-artifacthas v5actions/upload-artifacthas v4webfactory/ssh-agenthas v0.9.1
|
Hey @tdgroot Just so i'm clear, do you mean actually update your actions within |
|
I assume it's the markdown files, thank you for confirming :) |
tdgroot
reviewed
Oct 6, 2025
| DEPLOY_COMPOSER_AUTH: ${{ secrets.DEPLOY_COMPOSER_AUTH }} | ||
| - name: archive production artifacts | ||
| uses: actions/upload-artifact@v4 | ||
| uses: actions/upload-artifact@v5 |
There was a problem hiding this comment.
Latest major version of actions/upload-artifact is v4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few tweaks here to update github action
Update actions to supported versions
This action was also prohibited without an upgrade https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
Add a retention limit to the deploy artifact
To keep storage costs under control, by default aritfacts are stored for 90 days. A magento artifact can easilly be +500MB so these can add up quickly when deployments to staging are made.
Add
run-namefor variable nameThis allows us to see which specific branch triggered the deployment from within the github actions UI
You can see my image example
The top build was triggered with the following, which dynamically updates the run name based on the deployed branch.
This can be very useful for spotting production deploys in a sea of staging deployments.