fix: graceful-missing-trash-file#145
Merged
Byron merged 1 commit intoByron:masterfrom May 3, 2026
Merged
Conversation
…e missing trash files When a .trashinfo file references a file in trash/files that no longer exists, the assert! in metadata() and restore_all() would panic instead of returning a proper error. This caused cosmic-files to crash when encountering such orphaned trash entries. Replace assert! with ensure_virtually_exists() which returns a proper Error::FileSystem instead of panicking, allowing callers to handle the missing file gracefully.
Byron
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #119
Opened a PR for the same problem in cosmic files however, one of the maintainers recommended this be fixed here instead.