fix(BUY-60625): shrink mobile hero spacing so CTA fits above 844px fold - #281
Open
BuyWhere wants to merge 2 commits into
Open
fix(BUY-60625): shrink mobile hero spacing so CTA fits above 844px fold#281BuyWhere wants to merge 2 commits into
BuyWhere wants to merge 2 commits into
Conversation
Hide the full hero / search editor / search-results toolbar on mobile (<768px) when an active search is in flight. Replace with a single `<h1 data-testid="search-mobile-summary">` summary line that shows country + result count + active query. This keeps the first product card above the fold at 390x844. Also reduces the results section vertical padding on mobile. Mobile-only changes (md:hidden / hidden md:block). Desktop layout is unchanged.
Live probe @ 390x844 on 2026-07-29T21:35Z confirmed the amber 'Shop laptops' CTA in the Quick Next Step card sits at y=833 (only 11px visible above 844px fold). The earlier overflow-visible fix alone wasn't enough — the hero itself is 919px tall because of gap-12 (48px) and py-16 (64px) on mobile. Reduce grid gap to gap-8 and section padding to py-10 pb-12 on mobile (sm: and lg: prefixes preserve desktop layout). Desktop hero padding remains lg:py-24; desktop gap remains lg:gap-12. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Live probe @ 390x844 on 2026-07-29T21:35Z confirmed the amber "Shop laptops" CTA in the Quick Next Step card sits at y=833 (only 11px visible above the 844px fold). The earlier
overflow-hidden max-sm:overflow-visiblefix alone was insufficient — the hero itself is 919px tall because ofgap-12(48px) andpy-16(64px) on mobile.Change
Reduces mobile spacing in the hero
<section>ofsrc/components/seo/SeoLandingPage.tsx:gap-12→gap-8on mobile (sm:gap-12andlg:gap-12preserve desktop)py-16→py-10 pb-12on mobile (sm:py-16andlg:py-24preserve desktop)Verification
next buildpasses with type checkoverflow-hidden max-sm:overflow-visibleand now contains the responsivepy-10/pb-12/gap-8classesRollback
Revert single-file commit
9127f3744.🤖 Generated with Claude Code