Return the correct state if accept_eof matches#140
Open
noeddl wants to merge 1 commit intoBurntSushi:masterfrom
Open
Return the correct state if accept_eof matches#140noeddl wants to merge 1 commit intoBurntSushi:masterfrom
noeddl wants to merge 1 commit intoBurntSushi:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When implementing
accept_eoffrom theAutomatontrait I noticed that it did not behave as I expected when using the automaton in asearch_with_state. In cases in whichaccept_eofproduced a match the state returned in the stream was not the one returned byaccept_eof.The fix in this PR works well for my use case, I hope it confirms to how
accept_eofis intended to work.