Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the staff engineering discussion earlier this week, it sounds like we like the idea of removing any rules that could be enforced with a linter or which do not reflect our code base. I suspect a good rule of thumb here is is this rule worth memorizing and nudging in code review? If not, I suggest we lint if desired and toss the rule.
This pull request suggests removing most of the rules in the ruby section since they are lintable and, in some cases, we don't seem to employ them. Wide open to any feedback, especially if you see any rules in here you feel really strongly about.
Once we agree on which rules to remove from this guide, I believe the next step would be to go deeper on the remaining ones by creating dedicated pages with examples for them.