Skip to content

support connectionData for event subscriberDidConnect #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
philolo1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

support connectionData for event subscriberDidConnect #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions HotBoxService/HotBoxNativeService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class HotBoxNativeService : NSObject {
let publisherStreamDidFailWithError = Variable<String?>(nil)
let publisherStreamDestroyed = Variable<String?>(nil)

let subscriberDidConnect = Variable<String?>(nil)
let subscriberDidConnect = Variable<[String : Any?]>([:])
let subscriberDidFailWithError = Variable<String?>(nil)
let subscriberDidDisconnect = Variable<String?>(nil)
let subscriberVideoEnabled = Variable<String?>(nil)
Expand Down Expand Up @@ -306,7 +306,10 @@ extension HotBoxNativeService: OTPublisherDelegate {
extension HotBoxNativeService: OTSubscriberDelegate {

func subscriberDidConnect(toStream subscriber: OTSubscriberKit) {
subscriberDidConnect.value = subscriber.stream?.streamId
subscriberDidConnect.value = [
"streamId" : subscriber.stream?.streamId,
"data" : subscriber.stream?.connection.data
]
}

func subscriber(_ subscriber: OTSubscriberKit, didFailWithError error: OTError) {
Expand Down
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ session.on('sessionDidConnect', () => console.log('connected'))
session.on("sessionDidDisconnect", () => console.log('disconnected'))
session.on('publisherStreamCreated', () => console.log("PUBLISHER CREATED"))
session.on('sessionStreamCreated', () => console.log('sessionStreamCreated'))
session.on('subscriberDidConnect', (streamId) => console.log("New subscriber", streamId))
session.on('subscriberDidConnect', ({streamId, data}) => console.log("New subscriber", streamId))
session.on("subscriberDidDisconnect", (streamId) => console.log("Subscriber disconnected", streamId))
session.on('sessionStreamDestroyed', (streamId) => console.log("Stream destroyed", streamId))

Expand All @@ -82,7 +82,7 @@ session.createSession(apiKey, sessionId, token)
* publisherStreamCreated (streamId)
* publisherStreamDidFailWithError (err)
* publisherStreamDestroyed (streamId)
* subscriberDidConnect (streamId)
* subscriberDidConnect ({streamId, data})
* subscriberDidFailWithError (streamId)
* subscriberDidDisconnect (streamId)
```
Expand Down Expand Up @@ -153,4 +153,4 @@ Thanks to the following projects for inspiration!

## Issues?

Feel free to open an issue, submit a PR or email [email protected] to give feedback / suggestions.
Feel free to open an issue, submit a PR or email [email protected] to give feedback / suggestions.